[CMake] Add support for WebAssembly target architectures#408
Merged
kateinoigakukun merged 1 commit intoapple:release/1.1from Aug 1, 2024
Merged
[CMake] Add support for WebAssembly target architectures#408kateinoigakukun merged 1 commit intoapple:release/1.1from
kateinoigakukun merged 1 commit intoapple:release/1.1from
Conversation
Contributor
Author
|
@swift-ci test |
33 tasks
lorentey
reviewed
Jul 31, 2024
Member
lorentey
left a comment
There was a problem hiding this comment.
Looks good! Did you mean this to target the main branch instead of release/1.1?
To repair the swift-corelibs-foundation build on WebAssembly, we need to add support for Wasm targets to swift-collections' CMake build system.
612c883 to
effb335
Compare
Contributor
Author
|
@lorentey You are right, this should target |
Member
|
@swift-ci test |
Contributor
Author
|
@swift-ci test macOS |
Contributor
Author
|
Hi @lorentey, do we have any chance to release a new 1.1.x tag including this change? We need this change to repair Foundation build on Wasm. Thanks in advance 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To repair the swift-corelibs-foundation build on WebAssembly, we need to add support for Wasm targets to swift-collections' CMake build system.
Checklist